Matt Joiner

Results 837 comments of Matt Joiner

In cpu 2, the CPU usage of `Peer.maybeUpdateActualRequestState` is very high. That will choke/starve the upload routine. The memory usage isn't bad, I think I see you are using the...

I think we might need to make a few of the changes suggested in that issue. I don't have a Samsung TV to test.

Oh wow, nice work. Thank you for confirming @skunkie's fix. If you are having success with it, I could issue a new release if we don't yet have one that...

Seems weird, shouldn't the dual stack stuff take care of this? Can't you specify just `:1338`? I know on some platforms it's not automatic that implies INADDR_ANY, I've seen plenty...

I believe it might be better to use net.ParseIP then check for Is6 or Is4 to select the family.

There is net.Split or Parse HostPort or something to that effect. I'm on my phone or I'd check but I'm sure it's in there

Did you mean to have strings.Contains(... "::") or have I missed something?

Ah, I mean I might want to listen on a IPv6 address that isn't just ::. That also requires explicit tcp6 network on bsd? If not we're good to go

It should be possible to not modify dms to use your thumbnailer if the name is ffmpegthumbnailer? I don't quite follow the reasoning on why changes are needed per your...

Hm I was going to suggest you can just use ffmpeg but I see your wrapper just does that anyway.