Amy Evans

Results 48 comments of Amy Evans

@aimane-chnaif I see you added the 👀 emoji above but I'm not sure when you added it 😅. Will you be able to put this PR through its paces today?

Oops, sorry I missed this earlier in the week! Interesting, so we're hitting this block: https://github.com/Expensify/App/blob/ea3d65647108267c422bac5cbc4c5b7621e3e48f/src/pages/workspace/reimburse/WorkspaceReimburseView.js#L168-L173 and return early. That is hit because when we create a workspace optimistically on...

I mean that, currently, the reimburse expenses page is full opacity when offline: ![Screenshot 2023-04-18 at 11 22 20 AM](https://user-images.githubusercontent.com/7277067/232825037-2dd884b9-9085-4d21-902f-ab36784a8581.png) which implies to the user that they can set a...

Anyway let's label `External` to get some community input 😄

Okay sounds like we want to fully support Pattern B here and allow rate and unit configuration while offline, and also stay mindful of full Pattern B support as we...

> I think we agree this should be turned into Pattern B, and in which case we need to add optimistic custom unit IDs, right? Does that force us to...

Proposal looks great, assigning you @bernhardoj 🎉 We should be able to close out https://github.com/Expensify/App/issues/16211 as a byproduct of the bug fix as well 💪, 2 🐦 1 🥌