Deploy Checklist: New Expensify 2024-02-05

[github-actions[bot]]

trafficstars

Release Version: 1.4.37-7 Compare Changes: https://github.com/Expensify/App/compare/production...staging

This release contains changes from the following pull requests:

• [x] https://github.com/Expensify/App/pull/28002
• [x] https://github.com/Expensify/App/pull/34075
• [ ] https://github.com/Expensify/App/pull/34092
• [ ] https://github.com/Expensify/App/pull/34150
• [x] https://github.com/Expensify/App/pull/34564
• [ ] https://github.com/Expensify/App/pull/34580
• [ ] https://github.com/Expensify/App/pull/34640
• [x] https://github.com/Expensify/App/pull/34657
• [ ] https://github.com/Expensify/App/pull/34842
• [x] https://github.com/Expensify/App/pull/34863
• [x] https://github.com/Expensify/App/pull/35062
• [x] https://github.com/Expensify/App/pull/35077
• [x] https://github.com/Expensify/App/pull/35136
• [x] https://github.com/Expensify/App/pull/35186
• [x] https://github.com/Expensify/App/pull/35219
• [x] https://github.com/Expensify/App/pull/35222
• [x] https://github.com/Expensify/App/pull/35232
• [x] https://github.com/Expensify/App/pull/35321
• [x] https://github.com/Expensify/App/pull/35329
• [x] https://github.com/Expensify/App/pull/35354
• [x] https://github.com/Expensify/App/pull/35356
• [x] https://github.com/Expensify/App/pull/35360
• [x] https://github.com/Expensify/App/pull/35402
• [x] https://github.com/Expensify/App/pull/35453
• [x] https://github.com/Expensify/App/pull/35454
• [x] https://github.com/Expensify/App/pull/35460
• [x] https://github.com/Expensify/App/pull/35510
• [x] https://github.com/Expensify/App/pull/35536
• [x] https://github.com/Expensify/App/pull/35557
• [x] https://github.com/Expensify/App/pull/35573
• [x] https://github.com/Expensify/App/pull/35576
• [x] https://github.com/Expensify/App/pull/35601
• [x] https://github.com/Expensify/App/pull/35643
• [x] https://github.com/Expensify/App/pull/35646
• [x] https://github.com/Expensify/App/pull/35668
• [x] https://github.com/Expensify/App/pull/35762
• [x] https://github.com/Expensify/App/pull/35773
• [x] https://github.com/Expensify/App/pull/35796
• [x] https://github.com/Expensify/App/pull/35807
• [x] https://github.com/Expensify/App/pull/35825
• [x] https://github.com/Expensify/App/pull/35828
• [x] https://github.com/Expensify/App/pull/35849
• [x] https://github.com/Expensify/App/pull/35900
• [x] https://github.com/Expensify/App/pull/35916
• [x] https://github.com/Expensify/App/pull/35918
• [x] https://github.com/Expensify/App/pull/35924
• [x] https://github.com/Expensify/App/pull/35937
• [x] https://github.com/Expensify/App/pull/35953

Deploy Blockers:

• [x] https://github.com/Expensify/App/issues/35782
• [x] https://github.com/Expensify/App/issues/35892
• [x] https://github.com/Expensify/App/issues/35893
• [x] https://github.com/Expensify/App/issues/35894
• [x] https://github.com/Expensify/App/issues/35895
• [x] https://github.com/Expensify/App/issues/35901
• [x] https://github.com/Expensify/App/issues/35904
• [x] https://github.com/Expensify/App/issues/35909
• [x] https://github.com/Expensify/App/issues/35914
• [x] https://github.com/Expensify/App/issues/35915
• [ ] https://github.com/Expensify/App/issues/35919
• [x] https://github.com/Expensify/App/issues/35942
• [x] https://github.com/Expensify/App/issues/35944
• [x] https://github.com/Expensify/App/issues/35966
• [x] https://github.com/Expensify/App/issues/35974

Deployer verifications:

• [ ] I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• [ ] I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• [ ] I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[marcaaron]

Quick heads up that the latest app versions are not yet available, but we are working on it.

[kavimuru]

@marcaaron please let us know when we can start the regression once the latest version available. I can see 1.4.37-0 in web, mweb and android

[marcaaron]

All versions should be successfully updated now!

[kavimuru]

@marcaaron are we okay to test in 1.4.37-0. I don't see 1.4.37-1 version though.

[OSBotify]

:rocket: All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.37-0 :rocket:

[marcaaron]

Hmm I believe so. I don't think there is a real 1.4.37-1 and that was just a quirk of the failed initial deploy - but double checking...

[marcaaron]

I am 99% certain that the 1.4.37-0 has everything 👍

[rlinoz]

Demoting https://github.com/Expensify/App/issues/35892

[luacmartins]

Checking off https://github.com/Expensify/App/issues/35893. expected behavior

[kavimuru]

Regression is 34% progress #28002 to be validated in all the platforms #34092 to be validated in all the platforms #34150 to be validated in all the platforms #34564 to be validated in all the platforms #34657 to be validated in all the platforms #34842 to be validated in all the platforms #35062 to be validated in all the platforms #35232 to be validated in all the platforms #35454 to be validated in all the platforms

#34580 failing with #35919 #35460 failing with same KI #34961 (web, desktop) OK to check it off? #35557 failing with KI #34437 (web, desktop) OK to check it off? #34640 failing with #35914

[kavimuru]

Regression is at 60% #34580 failing with #35919 #35460 failing with same KI #34961 (https://github.com/Expensify/App/pull/35460#issuecomment-1930174774) - Repro in PROD check it off. #35557 failing with KI #34437 (https://github.com/Expensify/App/pull/35557#issuecomment-1930250575) - Repro in PROD check it off. #34640 failing with #35914 #28002 failing with KI #34151 in all the environments (https://github.com/Expensify/App/pull/28002#issuecomment-1930574718) - Repro in PROD check it off. #34092 failing with #35942 #34150 failing with #35901 #34842 failing with #35895

[amyevans]

Demoted #35914

[rlinoz]

Checking off https://github.com/Expensify/App/issues/35942

[aldo-expensify]

Checking off https://github.com/Expensify/App/issues/35915

[neil-marcellini]

Checking off and closing https://github.com/Expensify/App/issues/35966 because it's not a real problem

[marcaaron]

Checked off #35974 as it feels very niche

[marcaaron]

Checking off #35909 as it is not reproducible

[marcaaron]

Checking off #35904 as per this comment

[marcaaron]

Checking off #35919 as I confirmed it is fixed in the TestFlight build.

[mvtglobally]

Regression i at 5% left

@marcaaron Can you check if these are ok to check off? https://github.com/Expensify/App/pull/34092 failing with https://github.com/Expensify/App/issues/35942 https://github.com/Expensify/App/pull/34150 failing with https://github.com/Expensify/App/issues/35901 https://github.com/Expensify/App/pull/34580 failing with https://github.com/Expensify/App/issues/35919 https://github.com/Expensify/App/pull/34640 failing with https://github.com/Expensify/App/issues/35914 https://github.com/Expensify/App/pull/34842 failing with https://github.com/Expensify/App/issues/35895

[marcaaron]

Yep those are all done. Thanks!

[Julesssss]

I can verify that all but one of these issues have been CP'd and fixed, so I checked them off. I just need to look into https://github.com/Expensify/App/issues/35914, as a new bug has been raised against it 👁️

[Julesssss]

I'm checking off the final PR. The issue raised against it was deemed not to be a blocker.

[Julesssss]

• App timing: nominal
  • Android:
    • One exception is a bit worrying, but it has occured in many previous releases, so it's not a blocker. Possibly due to Hybrid app testing
  • iOS: No new crashes either. I see a couple of exceptions from a pre-existing issue, that is possibly the same as the Android crash above
• Github: ✅

[Julesssss]

:shipit:

[os-botify[bot]]

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval. Reopening!

[Julesssss]

Checked off the Firebase box...

[Julesssss]

:shipit: