amuse icon indicating copy to clipboard operation
amuse copied to clipboard

Move amuse.ext.molecular_cloud to amuse.ic.molecular_cloud?

Open rieder opened this issue 6 years ago • 3 comments

This seems to make more sense - especially since it's already in the list of initial condition imports in lab.py.

In general, I think "ext" modules should be for "extensions" / "external" modules? E.g. things that either exist elsewhere in AMUSE in a different form (bridge.py), or modules that are not (yet) part of the AMUSE core (e.g. fresco & masc).

rieder avatar Jul 29 '19 16:07 rieder

yea..I think it has stuff in there that is used in other places though..

ipelupessy avatar Jul 29 '19 18:07 ipelupessy

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 365 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 19 '25 02:11 stale[bot]

Looking in the ext/ directory the following should be moved to ic/

  • boss_bodenheimer.py
  • cloud.py
  • evrard.py --> Namely, the functions uniform_unit_sphere() and uniform_unit_cube()
  • galactics_model.py
  • gasplummer.py
  • molecular_cloud.py
  • protodisk.py
  • sink.py
  • sobol.py
  • solar_system.py
  • spherical_model.py

Additionally, the scripts ext/kingmodel.py, ext/plummer.py and ext/salpeter.py can all be deleted unless it is preferable to keep a deprecated warnings message in which case. The script ext/halogen_model.py also seems redundant, with it essentially wrapping community/amuse_halogen/

ErwanH29 avatar Dec 02 '25 11:12 ErwanH29