amuse icon indicating copy to clipboard operation
amuse copied to clipboard

Use "interaction_radius" as alternative to "radius" for collision detection

Open rieder opened this issue 5 years ago • 3 comments

Currently, collision detection in e.g. ph4 uses the 'radius' property of particles.

It would be beneficial to have an optional 'interaction_radius' property (not sure of the name), which would take precedence over the 'radius' property if defined.

This would make 'radius' available to store the actual stellar radius from stellar evolution.

rieder avatar Jul 26 '19 11:07 rieder

Did we actually ever make a move on this? It would simplify a channel in my code to have the attributes split.

~ Joe G.

JPGlaser avatar Jul 18 '20 16:07 JPGlaser

We did not. But I’m still in favour of doing this.

rieder avatar Jul 18 '20 16:07 rieder

Circling back to this because I am getting back to active development, I can implement the change and do a merge request. @rieder 's idea of just having it check for a interaction_radius in the gravity codes and use it over radius seems like the most straight forward method that wouldn't involve any major changes to documentation.

However, we should decide on exactly what we want to call it.

~ Joe G.

JPGlaser avatar Nov 18 '20 16:11 JPGlaser