amuse icon indicating copy to clipboard operation
amuse copied to clipboard

LimePy broken

Open LourensVeen opened this issue 1 year ago • 2 comments

Describe the bug LimePy does not work, because it uses SciPi features that no longer exist.

To Reproduce Try to import amuse.ic.limepy.

Expected behavior I expect LimePy to become available.

Logs

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/lourens/.miniconda3/envs/amuse-dev/lib/python3.12/site-packages/amuse/ic/limepy.py", line 7, in <module>
    from ._limepy import limepy, sample
  File "/home/lourens/.miniconda3/envs/amuse-dev/lib/python3.12/site-packages/amuse/ic/_limepy/__init__.py", line 7, in <module>
    from .limepy import limepy
  File "/home/lourens/.miniconda3/envs/amuse-dev/lib/python3.12/site-packages/amuse/ic/_limepy/limepy.py", line 8, in <module>
    from scipy.integrate import ode, simps, quad
ImportError: cannot import name 'simps' from 'scipy.integrate' (/home/lourens/.miniconda3/envs/amuse-dev/lib/python3.12/site-packages/scipy/integrate/__init__.py). Did you mean: 'simpson'?

Environment (please complete the following information):

  • OS and version: KUbuntu Linux 22.04
  • Compiler: N/A

Additional context See also #758.

LourensVeen avatar Jan 21 '25 15:01 LourensVeen

simps is indeed renamed to simpson, no other change necessary.

rieder avatar Jan 21 '25 17:01 rieder

Unfortunately, this isn't the only problem. There's also scipy.random , and that doesn't have a clear replacement IIRC. I looked at this at some point in the past, it'll require some work to get this working again.

LourensVeen avatar Jan 21 '25 18:01 LourensVeen