amuse icon indicating copy to clipboard operation
amuse copied to clipboard

Update ci.yml

Open rieder opened this issue 1 year ago • 5 comments

rieder avatar Apr 23 '24 13:04 rieder

Nice, but we should probably pick one tool and not run two, as they may end up fighting each other. Also, possibly ruff should be under consideration too?

yes we should decide which tool(s) we would want. black and flake8 don't do exactly the same thing, so for checks we may want to use both. Or ruff, I'll have a look at that too.

rieder avatar May 01 '24 19:05 rieder

@LourensVeen I'm not sure how to test the auto-fix part of this, do you have any ideas for that?

rieder avatar May 08 '24 19:05 rieder

I've tested it on a different repository now. The linter will push a fix to the branch in the PR, which seems fine to me.

rieder avatar May 12 '24 13:05 rieder

I'm just not sure yet if this will fix only the files affected by the PR (which should be how this works) or if it checks all other files too (which I really really don't want). Need to be sure of that before merging.

rieder avatar May 22 '24 08:05 rieder

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 21 '24 18:07 stale[bot]