Amr Shahin

Hello, What's required to support tensor2tensor? I can work out the code details

Hello, I need this as well, i can do the changes myself if you can point me in the right direction on which files to change etc ...

Well the main reason is that the library is smaller than icu, if you check the cmake file you'll notice that you have to link 5.a files from icu to...

Hey @galkahana , any idea when you're planning to merge?

Alright thanks man, let me know if i can help with any of those (except making it work for PC)

@nashwaan can you provide a fully working cpp sample that shows the problem, i'm back on tackling this issue.

@reemshahban It's fixed on my fork but it's not been merged. If I remember correctly @galkahana said it needs to be tested on Windows before we can merge. Would you...

Looks good to me but @galkahana has some concerns on using fribidi only, would you be able to test icu as well?

Sounds good, tbh i have no experience whatsoever with building on windows so i can't really comment, best get a review from @galkahana and then possibly merge. Thanks @MarcoMartins86

Ah! thanks! Can you provide a sample code that causes the memory leak?