Adrian Mouat

Results 163 comments of Adrian Mouat

FWIW I have exactly this issue at the minute. I just went with the temporary fix of allowing exactly 1 to 3 levels of naming: https://github.com/ContainerSolutions/trow/blob/master/src/routes.rs#L125 Fixing this would make...

It's probably worth pointing out that Docker Distribution supports S3 as a backend. It may be worth checking out how they do things: https://github.com/docker/distribution/blob/7d9f0677169fade147c0f99bda35c106e0d8a8fb/registry/storage/driver/s3-aws/s3.go

Yes, I can have a go. But I'm not 100% sure what the actual behaviour is around some of my questions. I'll take a look at the Docker client and...

This is a good point, but maybe the title is a bit misleading - what you're really asking is that tags support the "+" character, right?

To gather more context, the image spec does talk a *little* about tags. In particular note that https://github.com/opencontainers/image-spec/blob/e562b04403929d582d449ae5386ff79dd7961a11/image-layout.md#indexjson-file mentions > A common use case of descriptors with a "org.opencontainers.image.ref.name" annotation...

@sudo-bmitch deletion is an interesting one. I would say no, but for legal reasons, you probably have to allow some form of delete. Instead of normal deletion, once "deleted" the...

@justincormack just to confirm; in your view all clients should be required to understand manifest lists? (I think that's fair, I just want to be explicit).

I note that harbor uses the term "replication" rather than proxy-cache or mirroring, which I quite like https://goharbor.io/docs/1.10/administration/configuring-replication/

I *guess* the idea behind deleting by manifest is that it unambiguously deletes something - regardless of which tags point to the manifest, that manifest and all tags pointing to...

Thinking about it more, I *guess* the reason tag deletion wasn't added was because of the ambiguity as to whether deleting a tag removes any data or other tags. As...