Amos Bird

Results 147 comments of Amos Bird

> CH Inc sync - tests failed @jkartseva It looks like some tests in the private repo are failing. This might be related to the behavioral change introduced in this...

> I don't see that the failure in private is related to this PR, it looks like an error in our CI infra. Asking around.. @jkartseva I’ve resolved the merge...

> And now arm_tidy build is failing in private, but it's not related to this PR Cool. Is there any other blocker to merge this?

> The test test_graphite_merge_tree is in the skip list in private repository, which is why the asan_flaky check can't start properly, and this blocks private sync. Is this something we...

Thanks for the details! Is there any plan or existing support for reading locally stored compressed symbol files directly?

> A case that's not covered by this fix: ``` create table x (t Tuple(a int, b int)) engine MergeTree order by (); insert into x select (1 as a2,...

> please enable it back in a subsequent pull request. @alexey-milovidov Sure. I'll mention this backward incompatibility in the following PR https://github.com/ClickHouse/ClickHouse/pull/70103#issuecomment-2423417333