Amos Bird
Amos Bird
Test failures are related. The updated configuration does not include the necessary command-line flags. Need to investigate.
@antaljanosbenjamin It seems working.
> im curious if a clause like WITH SETTINGS ... would be feasible, and maybe a little more natural? A clause like `WITH SETTINGS` is indeed one of the options...
As discussed in telegram, we will adopt the `WITH SETTINGS` form. Amos Bird, [12/1/25 10:04 PM] Using SETTINGS is totally fine, but in this case we still need the parentheses....
> Looks good. Could you please add a test for one of the engines mentioned in the changelog? Sure. I've added more tests and fixed more issues.
> Looks like the tests has failed, unfortunately =\ It should be fine now.
> I wrote a test, unfortunately, it fails as following: Thanks! The test passes now.
I've updated the PR to address https://github.com/ClickHouse/ClickHouse/pull/37570 in a more general way, which also satisfies the second requirement of #4968.
Now it exposes additional issues: dependencies in default expressions are not handled correctly during column TTL. I’ll work on a proper fix.
Handling missing columns that have default expressions is non-trivial and currently unresolved (see https://github.com/ClickHouse/ClickHouse/issues/91127). For now, we conservatively avoid expiring such columns. PR is ready. @jkartseva @Felixoid Could you help...