Andrew Montalenti comments

Results 46 comments of


                                            Andrew Montalenti

live updates not working on firefox

I reported this in #16 a long time ago. At some point, the issue resolved for me, but for the latest livedown versions, I'm seeing the issue again. Linux (Ubuntu...

Consumer param `fetch_message_max_bytes` should be a soft limit

@jeffwidman Likewise, thanks for this -- assigning to @emmett9001.

pystorm/component.py: add new attribute self.storm_ui used log_file_n…

Hey @rainstyd, thank you for this, this looks like a nice contribution. I'll make sure one of the committers on pystorm takes a look at it!

Add a description of f-strings

Apologies for not seeing this for awhile -- poorly-configured email filters. I'm going to review this in December and hopefully merge in!

Suggest using `textwrap.dedent()` to keep indentation even with triple-quote multi-line strings

@maxalbert Thanks for this suggestion. I'll think about adding a reference to this to the guide.

The origin of the zen of Python

@marco-buttu -- nice sleuthwork! I heard this on a Python podcast a few months ago, so it was hearsay I never bothered to confirm. I think I'll update accordingly!

Try to use type hints

Love this suggestion! Thanks @Zeroto521. This is also related to #45 which I opened a couple weeks ago, and to PR #4 (which has been open way too long, I...

Add a note about the typing module and gradual typing

#48 is related.

Assignments/function calls in a return statement?

This is an interesting suggestion, thank you @gamesbook! I personally tend to follow your style (of setting a label for a complex calculation before issuing a `yield` or `return`). My...

Reconsider the advice on exception types

@lucaswiman I think you have a good point there. Thank you for the suggestion. I think this section will definitely get some rework soon.