Anton Moilanen

Results 38 comments of Anton Moilanen

Hi Tynael, Now js-crawler is using Node.js 'request' module to make requests. In the future versions it is possible to add support to using other request 'engines' such as PhantomJS....

Hi, thank you for filing the issue, I will take a look. Normally we would read the encoding from the HTTP headers, but maybe in this case it does not...

@Kwaadpepper @larminen I tried debugging the Print.js locally and it seems that: 1. It looks like this might not be a Firefox bug , but rather a Print.js bug 2....

@Kwaadpepper @larminen I guess the fix might be to allow the Firefox to render the iframe with the content we are about to print, but how to do it is...

@mjp89 Good find, confirming for Firefox 110 that the following change fixes the bug and PDF is printed: ```diff diff --git a/src/js/print.js b/src/js/print.js index e09e69f..deee4ca 100644 --- a/src/js/print.js +++ b/src/js/print.js...

Opened the PR https://github.com/crabbly/Print.js/pull/657 which should fix the issue

@crabbly Thank you for reviewing and merging the fix https://github.com/crabbly/Print.js/pull/657, could you, please, also release it to https://www.npmjs.com/package/print-js to enable support for Firefox >=110 ?

@crabbly When possible, could, you, please, release the fix? This might be a "blocker" with the latest Firefox for quite a few users, so your help will be very much...

@nunomgsantos80 Thanks, worked for me on Manjaro 4.19.28-1-MANJARO

Unfortunately now there is no special API for getting image urls from a given page and during crawling binary content such as images will be omitted by the crawler, instead...