node-oauth2-provider

node-oauth2-provider copied to clipboard

can you add/change this to your lovely little module ``` js } else if(req.method == 'POST' && self.options.access_token_uri == uri) { var client_id = req.body.client_id || req.query.client_id, client_secret = req.body.client_secret...

bmatusiak

oveddan

No unit tests

2

This library is great and has a lot of value, but such a core framework is dangerous to use without unit tests. Good unit tests would also provide documentation.

oveddan

Should stop catching all errors and instead callback with them.

2

The module's method of having wide try catch blocks and returning errors is not typical for node, and it leaves bugs undiscovered or harder to track down. It should either...

oveddan

Fix abuse of EventEmitter for callbacks

5

Maybe subclassing or delegation would be better...

ammmir

Support scope parameter in authorization request.

ammmir