node-oauth2-provider
node-oauth2-provider copied to clipboard
ammmir
Fix abuse of EventEmitter for callbacks
i'm not sure how serious i was about this... please provide some inspiration for a better api.
Events make sense if are likely going to have multiple listeners, but in this case, you're only going to provide a single listener to those events (in-fact, because you're passing a callback, multiple listeners doesn't even make sense). Just provide overridable functions.
// roughly
var provider = OAuth2Provider.create({
access_token: function() {
},
lookup_grant: function(client_id, client_secret, code, next) {
},
create_access_token: function(user_id, client_id, next) {
},
save_access_token: function(user_id, client_id, atok) {
},
remove_grant: function() {
// etc
}
})
You could also do it via dependency injection - I always prefer composition over inheritance:
The provider would act as an api, and contain a token repository. This way you have two cohesive classes, one is public facing and the other is purely responsible for saving data. You could still emit the event for backwards compatibility, but I would have that done through a contained EventEmitter rather than base one.
