Amit Subhash Chejara comments

Results 14 comments of


                                            Amit Subhash Chejara

DOC: fix docstring validation errors for `pandas.Timestamp`

I think all the tasks are picked already 😅.

Update documentation for floating-point precision and determinant calculations

Thank you @mattip for the feedback! I’ve made the changes to reflow the text and updated the commit message as suggested. Regarding the placement of the floating-point precision note, do...

Update documentation for floating-point precision and determinant calculations

Thank you for the suggestion @jakevdp. I have made the changes as suggested.

Update documentation for floating-point precision and determinant calculations

Thank you for the suggestion @eric-wieser! I've updated the section to use `np.linalg.cond()` instead of `np.isclose()` as you recommended. This should now provide a better indication of matrix stability. Please...

Update documentation for floating-point precision and determinant calculations

Yeah, that's what I thought. So I have updated the example to reflect a more general case of floating-point arithmetic as per your feedback. I removed the determinant-related example and...

Update documentation for floating-point precision and determinant calculations

Thank you everyone for your assistance throughout.

BUG: `str.split("")` gives extra leading and trailing elements

Since you are trying to split around `""`, which is not even a whitespace, the split method splits the given string around nothing. So there is nothing before and after...

BUG: `str.split("")` gives extra leading and trailing elements

I think str.split() is a good way, how do you want to split? @auderson

BUG: `str.split("")` gives extra leading and trailing elements

This is working: ```python import pandas as pd import re vals = ["foo", "", None] pd.Series(vals).str.findall(r"(.)", flags=re.IGNORECASE).to_list() # Output: [['f', 'o', 'o'], [], None] ```

[ENH] Allow `TorchExperiment` metric to set "higher is better"

Okay I will check this.