Amit Jain

Results 12 comments of Amit Jain

New PR which incorporates the review comments https://github.com/apache/jackrabbit-oak/pull/715

@neerajgrg The changes lgtm. But have you run the full suite of tests? I would expect that the testing is done for atleast eu_ireland, us standard and one other maybe...

@neerajgrg Yes please run all tests not just this class.

Thanks @neerajgrg for confirming, will take over.

@neerajgrg is there a jira issue associated with the PR? Please create one if not available.

Created https://issues.apache.org/jira/browse/OAK-9128

Patch committed. Thanks! @neerajgrg this PR can be closed now.

Don't need a PR for it, will merge from trunk.

Alternate [changes](https://github.com/amit-jain/jackrabbit-oak/commit/9d0c53b62e8ff8a10438052796522afc4d6654c0) to remove dependency on the LZ4 for other modules and only introduce it for oak-run-commons/oak-run

LZ4 support moved to issue OAK-9968 & commit https://github.com/amit-jain/jackrabbit-oak/commit/e8b4a0617fc857f281d6dec967cd48f7e5a16450