Amin Alaee

Results 242 comments of Amin Alaee

export csv/json in utf-8

Hey, will you please take a look?

OSError stubs don't match actual types for TimeoutError subclass

@AlexWaygood According to https://docs.python.org/3/library/exceptions.html#TimeoutError and the corresponding `errno` https://docs.python.org/3/library/errno.html#errno.ETIMEDOUT should by default have a value, so on Linux `110` and on Windows `138` if I'm not wrong. I'll open an...

OSError stubs don't match actual types for TimeoutError subclass

That makes sense. Based on the PR I think it's not only the `TimeoutError` and other subclasses of `OSError` could be like this. Do we want to change all of...

Multiple Admin Panels for the same fastapi App

I think it looks ok, but what is your use-case? Why do you need this in one app?

Internal Server Error relationship field

Please update your issue with basic code to reproduce the issue and traceback of what is going on.

Make login_required work with Fastapi routes

Yeah let's close it and continue the discussion in the PR 👍

Ability to access db session inside on_, after_ hooks

I'm ok with adding it to the signature, but can't you use the `session_maker` attribute on the `ModelView`? Is it a different session you need to pass to these hooks?

Fix: Cannot update value of attribute with reserved name when it starts empty

Thanks for the PR. I think it is strange this is happening since we already added some logic to rename WTForm private fields internally with `WTFORMS_ATTRS_REVERSED`. I think a good...

Custom view is not shown as active in the menu

PRs are welcome, otherwise I will get to this whenever I get a chance.

Fix fastapi root path o2m m2m search

@mmzeynalli I was waiting for [this](https://github.com/aminalaee/sqladmin/pull/962#discussion_r2555731578) comment to be resolved. I think it's a small change but we should also add tests for it