Amin Alaee

Results 230 comments of Amin Alaee

I don't think it's that straightforward. Even our `uuid4` can be unsafe: ```py import sys import uuid_utils sys.modules["uuid"] = uuid_utils import os import uuid a = uuid.uuid4() print(f"a = {a}")...

I will do some benchmark tests locally and get back to this PR. Sorry it took so long.

not really, it's a benchmark how PyO3 handles this and how it will affect our benchmarks.

@kamilglod I think the change should be really simple, we have to refactor this: https://github.com/aminalaee/sqladmin/blob/d99817aa25edf9039e381f42f5ea2a351457e012/sqladmin/application.py#L84C21-L89C85 I will take a look when I get a chance, or feel free to pick...

I think you should probably override `get_save_redirect_url` on a custom `Admin` class here: https://github.com/aminalaee/sqladmin/blob/a5f6d13f261f643e768fb35ce8559869d6d8273e/sqladmin/application.py#L665

Hi, Just a question, what is your expected behaviour here? I'm guessing you don't want to be able edit `created_at` and `updated_at` right? In that case you can just specify...

Sorry for the delay, I'm reviewing this now. I don't mind giving people access to managed this project more. Just need volunteers who can contribute a bit.

Thanks a lot for the PR, and sorry for my very late response. This will help a lot of people 👍

Hey, thanks for reporting this. - First thing is that you can pass your session_maker to `Admin(session_maker=...)` with the `expire_on_commit` so SQLAdmin doesn't have to create one for you. -...

> if you try using any field from the relation in That is expected. The SQLAlchemy session is closed at this point so you cannot load any relationship that was...