Amin Alaee

Results 192 comments of Amin Alaee

Which one do you think would be more appropriate here? How do we decide?

> I guess my preference would be if it _already_ returned a `URL` instance, rather than a string. > But given that it doesn't it's prob okay to just match...

> Given that both would be a breaking change I would strongly prefer the former I totally agree that returning a `URL` from `url_for` would be clear and explicit. But...

@adriangb I'm not sure how the deprecation will help. Now we are in 0.17.0 will we deprecate it in 0.18.0 or 1.0.0? I mean if we were on a major...

Let's wait for @tomchristie input on this.

I think there's also the possibility of doing something like Flask does: ```python url_for(name: str, **params: Any) -> str ``` To use any existing params as path parameters and use...

@Hazzari have you tried setting the loop on Motor client? ```python client = AsyncIOMotorClient() client.get_io_loop = asyncio.get_event_loop engine = AIOEngine(motor_client=client) ````

> https://github.com/encode/starlette/blob/master/docs/templates.md#asynchronous-template-rendering Yeah I mentioned if this is going to be merged the docs should be updated.

@plankthom Thank you for the PR. Can you please explain a bit about this? As far as I could see this was not really a bug, this was the intended...