starlette Add `AsyncTemplateResponse` to Jinja2Templates

Add `AsyncTemplateResponse` to Jinja2Templates

Open amisadmin opened this issue 2 years ago • 5 comments

Help Jinja2 make it easier and faster to use async template rendering.

Jun 23 '22 09:06 amisadmin

is this not valid anymore https://github.com/encode/starlette/blob/master/docs/templates.md#asynchronous-template-rendering ?

Jun 29 '22 07:06 euri10

https://github.com/encode/starlette/blob/master/docs/templates.md#asynchronous-template-rendering

Yeah I mentioned if this is going to be merged the docs should be updated.

Jun 29 '22 07:06 aminalaee

is this not valid anymore https://github.com/encode/starlette/blob/master/docs/templates.md#asynchronous-template-rendering ?

Subjective. Personally I think it's probably decent advice. But. 🤷‍♂️

Jun 29 '22 09:06 tomchristie

@amisadmin Are you still interested on working on this PR?

Aug 12 '22 17:08 Kludex

@amisadmin Are you still interested on working on this PR?

Yes, I am. But I'm a terrible document writer.

Aug 13 '22 02:08 amisadmin

I'm going to pass on this for the time being. We can come back to this after 1.0 is released.

Thanks for the PR, and sorry for the waiting time.

Feb 04 '23 09:02 Kludex