Amol Verma ( Dingus )

Results 16 comments of Amol Verma ( Dingus )

Hi @hkirat , can you please review this PR.

hey @foxylion , @edefaria , I am taking this up , can you guys share me the exact command and setup you are trying for, it will help me out...

Hey @neoandmatrix , I have been working for a while to fix this issue, lately have been busy so could not pick this up...I wont stop you, but if possible...

> what are you trying to achieve by merging main? It erases the CI checks which clearly show that your PR does not pass the linter. I was updating the...

I have made the corrections for Unit Tests, can you update the PR label please ? @yurishkuro and run it again, I dont have necessary permissions to add the label...

> what is the testing procedure for this change? How do we know it does what's needed? To verify this fix works, I've set up a test environment with: 1....

> > To verify this fix works, I've set up a test environment with: > > Is this something we can add to `internal/storage/integration/kafka_test.go`? Yes, we can add an integration...

> Yes, I prefer the tests to be part of the PR. However, is it possible to configure a single instance of Kafka to work with different auth-n methods, or...