Jesús Amieiro Becerra

Results 43 comments of Jesús Amieiro Becerra

> > Maybe as a separate PR as done in #1479? > > Yes, I'll wait for it to be merged. Will have to check wich alphabets use the words/characters...

Why not do this in the browser? We only need to get the UTC time from the database (with PHP) and then add the browser offset and the local data...

I don't think so (I am not sure), since we have to process it on one side or the other. We would have to do a performance test, but a...

Perfect. If we can translate the computation from the server to the browser without a lot of overheading, I think it could be interesting, so we improve the UX.

> > Why not do this in the browser? We only need to get the UTC time from the database (with PHP) and then add the browser offset and the...

> Which one is looking good ? I think the first one.

@sssumitsingh You need to open a pull request to integrate this change into the GlotPress core.

Hi @sssumitsingh You need to fork the project and then make a pull request from your fork to the main project. [Here](https://jarv.is/notes/how-to-pull-request-fork-github/) you can take a look with the steps

@sssumitsingh you have created 3 PR (https://github.com/GlotPress/GlotPress/pull/1437, https://github.com/GlotPress/GlotPress/pull/1438, https://github.com/GlotPress/GlotPress/pull/1439). Please, mix all the files in the same PR and remove the other 2 PR. The https://github.com/GlotPress/GlotPress/pull/1437 PR has the CSS...

You are using the [wp_timezone_string()](https://developer.wordpress.org/reference/functions/wp_timezone_string/), but this function _retrieves the timezone of the site as a string_. Shouldn't you get the user's timezone via JavaScript?