Amey Jadiye
Amey Jadiye
Hi @kinow , looks like all suggestions are accommodated with readable code and considerable performance. the code also mimics algorithm given on Wikipedia. test cases passing as well. do you...
@kinow @aherbert I have written code by keeping Wikipedia as standard and researched some other libraries from other languages just for reference. all of them are using bigrams for calculating...
@aherbert @kinow , however up and above the existing algorithm I liked the Idea of changing the code in #109 so the results will be ``` "aa" vs "aaaaaaaa" ==...
I'm okay with that either :) , and just overlooked #109. looks nice @aherbert . let me know if you guys merged it with trunk will make changes here as...
@kinow @aherbert changed my code and looks good to me now. please review.
@kinow @aherbert , this looks good to me now, can you please take a look.
@aherbert sounds a good idea, let me create another PR for that, will comeback on this.
@aherbert apologies I was busy with much other stuff, will have to go through this. this PR is real mess.
Hey, thanks for reminder @kinow , I will finish this asap. this PR became real mess though. ```squash``` will be real hard. I will try to incorporate @aherbert suggestions here...
@garydgregory - Long pending issue, its development lost in discussions. I'll go through it once again and try to finish. thanks for reminding for one. :)