Alex Meijer comments

Results 46 comments of


                                            Alex Meijer

[DO NOT MERGE] Plugin working branch

@nik-kc , PRs fixes are here https://github.com/opencost/opencost/pull/2625 , can you take a look?

Refactor allocation calculation

+1 I support this change. Test cases look good, maybe a bit more testing? I will take a closer look

Kubernetes cache optimization

we have merge conflicts here, and we also want to let the sonar quality gate pass which would require a merge

allow: set path for internal prometheus

@dodizzle would love to get this merged!

Explore use of string interning in OpenCost

@SerenaTiede-Zen , would you be willing to test https://github.com/opencost/opencost/commit/47c4b6817505df7cf6d3c7f21bf318f0c80fd94e (merged to develop as of 1/17/25), to see how the deduplication's memory is. We aren't using the string interning yet, wanted...

Refactor and add testing for Athena and S3 row parsing

@Sean-Holcomb LMK when you have test coverage and I will review!

fix: apply filter before aggregation in ComputeAllocationHandler

cclosing as dup of #3394

Bump github.com/stretchr/testify from 1.9.0 to 1.10.0

@dependabot recreate

fmtQueryCPUModePct is costly, consider adding label matchers

I see no issues with this as long as the configuration defaults to the existing values 👍

[LFX Mentorship] Integration Test Suite 1.0

hi @Rupam-It ! We would love help with this - it should be noted though that this issue has been submitted for a linux foundation mentorship as this will be...