Ambroz Bizjak
Ambroz Bizjak
Hi, thanks for looking into this. I'm using C++ (and the official C++ extension). I didn't do any special setup of the spell checker other than which file types are...
Windows build instructions are here: https://github.com/ambrop72/badvpn/blob/master/BUILD-WINDOWS-VisualStudio.md
Cool that this is fixed. I will try to find time to review this pull request.
Could you please add a copyright notice to SocksUdpClient.h/c, i.e. "Copyright (C) your_name_or_company", above the license terms text?
Thanks. I have already reviewed the other code, when I'm done with those last files I will merge with some fixups.
@bemasc, I have some comments/questions. > However, this implementation is currently limited to localhost SOCKS5 servers. SOCKS5-UDP does not perform well over actual network links, as it requires several roundtrips...
Hi, Looks like most of the HAL code was copied from the F4 code and just minor adaptations were made. I'm not comfortable merging this because this means I need...
Thanks for the explanation. About the board scripts, they are a remnant from time time ago and ideally all would be configurable via the "board" section in the configurator. I'm...
Sure that would be great if you try to merge this code. I am mostly concerned about the "real" code in the hal/ directory that I wrote. You can rename...
Hi, Thanks. I've reviewed your changes and generally it looks great. I have the following comments/questions. - What's the reason for the changes in Preprocessor_MacroMap.h (APRINTER_AS_NUM_MACRO_ARGS...)? Is some compiler processing...