Amartya Parijat
Amartya Parijat
@fedejeanne @HeikoKlare @akoch-yatta I have created the PR for Image. You can review it now.
Fixed the issue with the icon of the shell. But I have also created a follow up issue which addresses the problem in the depth but it doesn't have to...
> It seems that some fields added here will not be necessary in future PRs (see `Shell` and `Widget`), please remove them. > > Also, the method `GCData::setNativeZoomForGCData` suffers from...
> @amartya4256 merging the required PR introduced a conflict in this PR, so please resolve and rebase on master once you find the time This PR now depends on https://github.com/eclipse-platform/eclipse.platform.swt/pull/1258...
> Thank you for addressing my previous comment @amartya4256 , I just have one final change request to improve readability. After that, this PR is good to go from my...
We can close this issue now. It has been fixed by https://github.com/eclipse-platform/eclipse.platform.swt/pull/1548.
> Seeing the implementation, I am wondering whether it would also be sufficient to just add a `showsCustomText()` method instead of the `isLocationForCustomText(String)` one. Then the functionality would be completely...
> If `BASE_URL` is only used by the `Edge` class should that portion of code be moved there instead of being in the `Browser` class? And does it need to...
> This PR creates a temporary file and replaces the original implementation of `Edge#setText()` in all cases, even where `Edge#setText()` might not need it in the case of very simple...
Split the PR into 2 and moved the set text fix to #1395