Aman Khalid

Results 9 comments of Aman Khalid

`fgCompactBlocks` (and the rest of the JIT's flowgraph code, for that matter) has undergone a lot of churn lately. I'm no longer seeing that method come up in the backtraces...

Since this hasn't hit recently, I'm going to unmark `blocking-clean-ci` for now, and keep an eye on this. If it hits again, I'll revisit the crash dumps, and (if necessary)...

It's worth noting that the most recent failure (#100658) was from an intermediate commit that hit other issues in CI, so maybe that was a false positive? > Are all...

@riarenas no worries, sorry about that.

This hasn't hit on a "functional" CI run in quite a while. Are we ok with closing this?

The most recent hit was on a draft PR with other failures. Since we haven't had a failure block CI recently, I think we ought to close this to avoid...

Here's the diff summary on win-x64, since the RPO-based layout is disabled by default. Diffs aren't that big, and they aren't overwhelmingly in one direction... Diffs are based on 2,534,676...

cc @dotnet/jit-contrib, @AndyAyersMS PTAL. If you don't think it's worth churning the RPO layout implementation while running an experiment in the perf lab (especially since the diffs don't look like...

@jakobbotsch this cleans up the `BasicBlock` visitor API surface a bit. I initially tried something like the initializer pattern you mentioned over in #101473, but the current usage of `AllSuccessorEnumerator`...