Amal Murali

Results 3 issues of Amal Murali

The `goodip` comparison isn't working as expected here: https://github.com/vortexau/dnsvalidator/blob/b55b6f0930102f03c95c58c552d4eec64c30154a/dnsvalidator/dnsvalidator.py#L95 The reason is because `goodip` is getting overwritten in the loop: https://github.com/vortexau/dnsvalidator/blob/b55b6f0930102f03c95c58c552d4eec64c30154a/dnsvalidator/dnsvalidator.py#L126-L128 It would essentially mean that `goodip` value will have...

bug

Why are we not using [`guess_lexer_for_filename()`](http://pygments.org/docs/api/#pygments.lexers.guess_lexer_for_filename) or [`guess_lexer()`](http://pygments.org/docs/api/#pygments.lexers.guess_lexer) that's already available in Pygments for language-detection? I'm trying to understand if there's any added advantage of having the same thing rewritten...