Antonio Maiorano

Results 16 comments of Antonio Maiorano

> LGTM, thanks! What environment was this failing in? Ah, sorry for the lack of detail. This is failing internal builds at Google, specifically when building the clvk nvidia CTS,...

Hi again, is it okay to merge this?

> Yes, all fine to merge. Sorry for the slowness but I'm on holiday and not spending much time close to a computer. Oh, no worries! Sorry for bothering you...

Yep, #8 looks better, and I see it's already merged. Thanks! You can close this.

Hi there, If you disable RTTI, you'll need to add the DEFINE_HSM_STATE() macros in each of your states to inject the custom RTTI info needed by hsm. Check out the...

> So I downloaded the second latest release (1.5) and had to comment the line //static_assert(std::is_convertible::value, "TargetState must derive from hsm::State"); This assert is important, you should not remove it....

Hi @mjt123. Yes, you're right, and not the first to bring this up. I need to add a section to the Wiki/Book about how to do this. In the meantime,...

While we're at it, can we add an option to also delete the local branch when deleting the remote one? This is also a nuisance when working with feature branches...

I understand, but even with prune, this means I have to perform two separate actions to delete a single feature branch. I don't typically delete a bunch of remote branches...

> So deal with it. Salty much? There's no need to respond that way.