Adrian Macneil
Adrian Macneil
Despite this reference in `index.d.ts`, when upgrading from `xmldom:0.6.0` to `@xmldom/xmldom:0.7.2` typescript complained about missing dom libraries and I had to explicitly add `"lib": ["dom"]` to `tsconfig.json`. I'm not sure...
I agree, it is surprising behavior. I created a repro here: https://github.com/amacneil/xmldom-types-repro You can see the build output here: https://github.com/amacneil/xmldom-types-repro/actions/runs/1163442338 I found that for both the old and new version,...
There is lots of prior discussion about this: - https://github.com/amacneil/dbmate/pull/256 - https://github.com/amacneil/dbmate/pull/316 - https://github.com/amacneil/dbmate/pull/434 - https://github.com/amacneil/dbmate/pull/438 Including some thoughts I posted in https://github.com/amacneil/dbmate/pull/438#issuecomment-1545258004 I would like to see a proposal...
epic! let us know when ready for a review