Alya Abbott
Alya Abbott
Yeah, that extra margin seems reasonable with the bookend as well. @laurynmm are you up for reviewing this one? I haven't tested.
@PieterCK Looks like there are some test failures to fix for this PR to be ready for the next round of review.
I haven't tested since it's a draft, but the screenshots look nice! I guess some day we should rework the color picker, but it's not a big priority (#14961, and...
If I close the compose box without sending a message or pressing "Got it", the banner incorrectly appears again next time the compose box is open, regardless of context. ![CleanShot...
Also, is it possible to update the conversation in the banner? If it's not easy to do, let's rewrite the banner text to not include it, to avoid situations like...
I verified that the banner is correctly not triggered from Recent conversations.
The timing of the banner showing up when you click into the main compose area feels good to me.
@timabbott I think you can take a look next? I haven't re-tested.
Thanks! When playing with this, I noticed that there's a situation where the banner doesn't quite make sense. If you are in an interleaved view that doesn't include the conversation...
The way the banner text updates doesn't quite feel right. It seems to require clicking out of the main compose area and back into it again. So, e.g., if I...