Alya Abbott
Alya Abbott
@PieterCK would you be able to do an initial review pass here? @Mukul1235 Your commit titles are missing periods, so please fix that up as well.
Thank you for the thoughtful and detailed feedback, @icp1994 ! I flagged it on the [development community thread](https://chat.zulip.org/#narrow/stream/101-design/topic/.F0.9F.8E.AF.20.E2.9D.93search.20pills.20.2326803.3A.20new.20search.20behavior/near/1911137) where this behavior change was previously discussed.
@opmkumar Is there a reason this PR isn't tagged for buddy review?
Started [#design > advanced channel permissions @ 💬](https://chat.zulip.org/#narrow/channel/101-design/topic/advanced.20channel.20permissions/near/2188605) for a related UX issue. Not a blocker for moving this PR forward, but we should take care of it either before...
Otherwise looks good to me in manual testing!
Great, @sahil839 , could you please take a look at this one?
@amanagr could you please take a look at this one? I haven't tested.
Oh, it would have been helpful to link to the discussion on #31873 in your description!
@karlstolley are you the right person for the next round of review?
Is there an issue this PR is solving? Please link it if so.