Alya Abbott
Alya Abbott
@roanster007 It would be great to get this PR updated.
@timabbott do you want to take a look, or should someone else take the first review pass here?
@timabbott adding "integration review" too, since you have a prior review and there are replies to your feedback.
I like it overall!
For the error, can we make it specific?
Let's make the confirmation: ## Time zone updated Your time zone was updated to {time zone}.
Could you add an update to https://zulip.com/help/change-your-timezone to document the new setting?
The tooltip needs a delay. I also wonder if we should point it downwards, to avoid hiding the time zone.
In general, I think we don't have a pattern of putting tooltips directly on non-disabled settings. So, we may find that we need to stick onto a `?`, though we've...
Really, our standard approach would not involve a tooltip at all -- just a `?` link to the help center.