Alex Xiong

This is pretty impressive speed-up, but you pushed the instance to be 2^22 to make the gap meaningful, for much smaller instances (which is our case), the gap is so...

I stumble onto this stale PR yesterday, for those who want to use this FK23 today(Fast amortized KZG https://eprint.iacr.org/2023/033.pdf), we have an implementation in Jellyfish library. (relevant PR: [initial](https://github.com/EspressoSystems/jellyfish/pull/231) work,...

This is issue is for constraints (circuit implementation) of batch insertion.

Yes, arkwork defined the [`trait HashToCurve` here](https://github.com/arkworks-rs/algebra/blob/13fd33e33c1186b2757e3fd3948b6eee16ee9e4b/ec/src/hashing/mod.rs#L9), and implement it [here](https://github.com/arkworks-rs/algebra/blob/13fd33e33c1186b2757e3fd3948b6eee16ee9e4b/ec/src/hashing/map_to_curve_hasher.rs#L28) with flexibility for different hashing and mapping (from field to group) strategies. I think we can close it for...

this is a stale PR. iirc, the original motivation was just defense in depth in the light of [trailofbits' disclosure on FrozenHeart ](https://blog.trailofbits.com/2022/04/13/part-1-coordinated-disclosure-of-vulnerabilities-affecting-girault-bulletproofs-and-plonk/)where some FS transcripts forget taking in all...

> Is there any reference for old discussion about this issue? Sorry, I can't recall. @chancharles92 do you have anything to add beyond my comments above? > Also is the...

Thanks for finding the notion page. I have a question, so it's probably a good idea to fix "rescue transcript". But is it necessary to also add label to "solidity...

Some follow-up conversations here: https://github.com/RustCrypto/traits/issues/1087

So what's the status on this, it seems that we still have this problem even after @mrain's work on #135 ? `RescueCRHF::sponge_no_padding` is still internally calling [`Permutation::default()` here](https://github.com/EspressoSystems/jellyfish/blob/main/primitives/src/rescue/sponge.rs#L64), which essentially...

I agree with @sveitser, single responsibility principle when possible.