Alex Xiong
Alex Xiong
Ah.. what would you suggest we should do with serde test code for `ExpandedSecretKey` currently lives in integration test folder? Should we move all of them to unit tests in...
no, with `feature = "serde"` on, `De/Serialize` [are implemented](https://github.com/alxiong/ed25519-dalek/blob/alex-pk-oracle/src/secret.rs#L511-L532) for `ExpandedSecretKey` given now this struct is only internal `pub(crate)`, not sure how useful these serde function is. I'm just worried...
I feel that the following is more ergonomic: ```rust use ark_ff::PrimeField; use jf_relation::{errors::CircuitError, BoolVar, PlonkCircuit}; use crate::{ merkle_tree::{ prelude::{RescueMerkleTree, RescueSparseMerkleTree}, MerkleTreeScheme, UniversalMerkleTreeScheme, }, rescue::RescueParameter, }; /// Gadgets for rescue-based merkle...
flavoring #146
I'm able to reproduce the toy example (for throughput profiling) but when I'm trying to do simple latency profiling using `coz::scope!`, the profiler just runs and get stuck for hours:...
> 1. Check subgroups on deserialisation Note: I believe this is currently what the go bindings do? Pros - simple, secure, if points are cached in BLST format the subgroup...
as weekend fun, I wrote down how I think KZG in eval form should work here: https://www.notion.so/espressosys/KZG-in-Evaluation-Form-c58004c5ca7f427f92799aaeea7c6e1a literature note, Dankrad has indeed described how KZG in eval form should work...
@mrain @tessico do you think we should add this to `0.2.0` release milestone?
While doing #318, on my local M1, native benchmark: ``` $ cargo flamegraph --root --bench=plonk-benches --features test-srs proving time for Bls12_381, PlonkType::TurboPlonk: 52120 ns/gate proving time for Bls12_377, PlonkType::TurboPlonk: 53111...
yeah, I suspect you are right. so we really need to run inside wasmtime to get an accurate benchmark? @mike1729