Alvin Lin

Results 66 comments of Alvin Lin
trafficstars

@otterley do you mean you have someone who can work on updating the build workflow? I have not dive deep into what needs to be done, but at high level...

Hi, is your Prometheus sending HA labels? If so, this PR fixes a memory leak: https://github.com/cortexproject/cortex/pull/4739 If this is not the case, would you mind taking a heap profile?

Good to know @TaylorMutch :-)

@3Xpl0it3r can you resolve the conflict, then I'll approve this.

Hi damnever@ thank you for the PR, this is a nice change. May I ask you kindly add a CHANGELOG.md entry as well as add/update some tests? Thanks!

I am not sure if we should do info logging on the call path that may be high TPS. May have impact on latency.

Maybe have it to be debug log instead of info, or maybe like @alanprot suggested, use metrics instead of logs.

@siavashs Sorry for the delay, but I just remembered this pending PR. Would you kindly fix the lint error? Else the change looks good to me

@ilangofman may start to work on this again soon :) so not staled.