cortex
cortex copied to clipboard
Support Redis dns discovery
What this PR does: The go-redis options requires multiple redis addresses for a cluster. In some scenarios like AWS ElastiCache, a single configuration endpoint is used to resolve all cluster nodes.
This change adds experimental support for redis dns discovery. This is a similar implementation to memcached ds but with just a resolver.
Signed-off-by: Siavash Safi [email protected]
Which issue(s) this PR fixes:
Checklist
- [x] Tests updated
- [x] Documentation added
- [ ]
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]
Hi siavashs, first of all, thank you for the contribution!
There is actually a service discover through DNS mechanism for memcached called; here is the doc. For Redis I think we should be consistent and use similar way to configure DNS look up.
Hi @alvinlin123 Thanks for pointing that out. Yes, I think that's a better solution. I'll come back with a new implementation.
I've updated the PR to add support for dns discovery as suggested. I'll update the docs after your initial review.
@siavashs Sorry for the delay, but I just remembered this pending PR. Would you kindly fix the lint error? Else the change looks good to me
The CI tests have failed because of a timeout but I can't rerun them.
This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.