Kyle Altendorf

Results 572 comments of Kyle Altendorf

i would rather see the explicit pragma comment when reading the code making it obvious this is being ignored.

Thanks for the heads up on this. I just last night got back from a two week vacation. With https://github.com/pytest-dev/pytest-twisted/pull/184#issuecomment-2282914368 in mind, any opinions? Or, if you use pytest-twisted somewhere,...

I blazed my own path and (after forgetting for a couple weeks, sorry) just published https://pypi.org/project/pytest-twisted/1.14.3/.

Testing over in https://github.com/miniupnp/miniupnp/actions/runs/9893091795?pr=766 (from https://github.com/miniupnp/miniupnp/pull/766) suggests that this is at least working in the GitHub Windows builds (when enabled). @miniupnp, are you able to check this on AppVeyor as...

Looks to be working at https://github.com/miniupnp/miniupnp/actions/runs/9910239753?pr=767.

@miniupnp, welp, I'm back from a couple weeks of vacation. Just figured I'd check back on this.

I'm confident there is. I looked around a bit and didn't figure out a small quick thing. I think the make-based build is a bit inside out in this regards...

Has anything happened on this topic elsewhere?

This method here was a quick hack, not a proper solution. I appreciate your effort to do it the right way. I'll take a look at the next release and...

The 2.3.2 Windows wheels do look like they ought to work, though I haven't tested yet. Thanks! Still an issue with artifacts though as noted in https://github.com/miniupnp/miniupnp/issues/616#issuecomment-2704856140. `:]`