David Alsh
David Alsh
Rebased it: https://github.com/preactjs/preact/pull/4501
I just updated the PR to resolve conflicts. I can't run the test suite locally for some reason so I will wait for the pipeline to be unblocked to figure...
Hey, thanks for this PR, it's exactly what we need for a tool my team has been working on. I've created [automatically prebuilt binaries](https://github.com/alshdavid/libnode-prebuilt/releases/tag/pr-node-api-libnode) from this branch to experiment with...
> Submit changes to Node.js code as small PRs In that case, I'd prioritise merging in a minimal & unstable `node_embedding_main_run` as that is sufficient to get users on board,...
Hey @vmoroz, would you consider a smaller footprint PR to get started with? [Something like this](https://github.com/nodejs/node/compare/main...alshdavid-forks:node:alsh/node_embedding_api?expand=1) I'd imagine this isn't too contentious seeing as it's an unstable API with warnings...
> It is a bit surprising to hear that it covers a lot of scenarios. Yeah! It's a bit hacky because it requires JavaScript shims to get the functionality working....
My understanding is that the inclusion of TypeScript support in Nodejs is to simplify the development cycle - where distributed code should still be transpiled to JavaScript before consumption (npm,...
> The extension requirement comes from ESM support in Node which has always required a extension. I think it's a good requirement because it eliminates ambiguity when multiple files exist...
I also cannot use FSR on my ROG Ally
Here is a PR adding this via a `libnode` feature. https://github.com/napi-rs/napi-rs/pull/2876 And the PR for v2: https://github.com/napi-rs/napi-rs/pull/2880