Alvaro Revuelta

Results 56 comments of Alvaro Revuelta

Note that `protobuf-c.c` also relies on `malloc`. `protobuf_c__allocator` can be used to change the `alloc` and `free` functions. Can be a good idea to copy the way `protobuf-c.c` handles allocation.

Nice! Looks good to me. Slightly related to this, I think we need to discuss which configuration parameters we expect. For example, I see that currently you have the operators,...

> There are still quite few in the codebase and tiny yolo is not as tiny as the name suggests :D This was exactly was I was thinking when I...

Great that you find it useful :D > connxr is currently completely dependant on the onnx_generator makes customizations hard, since they would have to be in sync with the onnx_generator...

One more comment regarding `onnx_generator`. I see this as some kind of way of updating our repo to the latest onnx version. Hei! onnx released a new version. Ok, lets...

Fair request. I kind of ran into this when trying to use cONNXr [with Arduino](https://github.com/alrevuelta/cONNXr/blob/master/examples/arduino_example/Arduino_Example_ONNX/Arduino_Example_ONNX.ino) Is that the example you are referring to?

Yes, agree that we have some memory leaks. How did you find them? Unexpected crashes or were you using some tool like valgrind? Could you list the ones that you...

Could you provide the commands you used for the gcc address sanitizer? In the future some kind of memory leak detection should be included in the GitHub Action CI. Regarding...

This makes me think something that we have been avoiding from the beginning. We are currently testing the the operators using the onnx "test vectors". However, these "test vectors" don't...

Any thoughts on this? As I previously stated I don't think the default test vectors that onnx provides are sufficient for us. As I already suggested, I think we can...