govuk_publishing_components

govuk_publishing_components copied to clipboard

## What - include the code snippet from Google in our code for running GTM as part of our new analytics code - note that this will not work without...

andysellick

## What 1. Allows shift clicks to be tracked, using `event.shiftKey`. 2. Allows share and follow link clicks to be tracked, using a `data-ga4-link` attribute on `_share_links.html.erb`. 3. Tracks internal...

AshGDS

Bumps [@percy/cli](https://github.com/percy/cli/tree/HEAD/packages/cli) from 1.10.1 to 1.10.2. Release notes Sourced from @​percy/cli's releases. v1.10.2 What's Changed 🐛 Bug Fixes 🐛 Use a file URL when importing snapshot files by @​wwilsman in...

dependabot[bot]

## What Cosmetic changes to the feedback component. ## Why [Research suggested](https://docs.google.com/presentation/d/1_9VoSf_E-RtU2TuapSyIOAFTR1okpd05q8jzZds-AAQ/edit#slide=id.ga3daf72c81_0_153) that a number of issues need resolving longer term. However, in the short term we are improving the...

matthillco

Include size attributes on image card component

4

## What https://trello.com/c/iz7WJaeG/1404-include-width-and-height-size-attributes-on-image-card-component-2869 Include width and height size attributes on image card component - https://components-gem-pr-2895.herokuapp.com/component-guide/image_card - https://components-gem-pr-2895.herokuapp.com/component-guide/image_card/large_version ## Why See https://github.com/alphagov/govuk_publishing_components/issues/2863 ## Visual changes ### CLS (before) https://user-images.githubusercontent.com/87758239/183419165-41224472-c3b2-4bb2-bf3a-3e786f6b190f.mov ### CLS...

jon-kirwan

## What Replace unused classes in intervention component. ## Why The component has selectors for `govuk-link gem-c-intervention__suggestion-link` and `govuk-link gem-c-intervention__dismiss` which are only used for targeting in tests but has...

jon-kirwan

We might have to remove jQuery from our tests after all

2

Dependabot just raised [bump jasmine-core to 4.3.0](https://github.com/alphagov/govuk_publishing_components/pull/2873), which is producing several errors in the jasmine/JavaScript tests like this: ``` Uncaught TypeError: jasmine.util.argsToArray is not a function thrown ``` The gem...

andysellick

Inconsistent focus state on document list component

4

When the title in a document list goes onto a second line, the focus state then takes up the entire width of the parent element. This is due to `display`...

injms

Align the code for radio and checkbox component

1

## What We [recently did some work](https://github.com/alphagov/govuk_publishing_components/pull/1304) on both the checkboxes and radios components. The two components are very similar in function but have quite a different layout in code....

huwd

Accordion anchor link navigation breaks with invalid anchor

2

I'm not sure I fully understand the exact problem here but raising for further investigation. The accordion has an option to allow a [section to open based on the URL...

andysellick