Alok Priyadarshi

scribble.Driver.Delete returns an opaque error type for non-existent keys which makes it hard for the clients to distinguish between different kind of errors. This behavior is also inconsistent with the...

ypipe_conflate_t::reader_awake has data race

5

# Issue description TSAN reports data race on ypipe_conflate_t::reader_awake. # Environment * libzmq version (commit hash if unreleased): 4.3.4 * OS: Ubuntu 18.04 # Minimal test code / Steps to...

Remove unnecessary variable ypipe_conflate_t::reader_awake

1

This variable is not necessary because the only possible value is "false". This variable also had data race reported by TSAN. Fixes zeromq/libzmq#4369

TSAN reports data races

1

TSAN emits whole bunch of data race warnings on a simple single publisher, single subscriber application. Log attached. Threading model of the application: - Both publisher and subscriber are on...

Incorrect comments about non-blocking IO?

4

Comments for `ecx_outframe` and `ecx_recvpkt` claim non-blocking `send` and `recv` respectively: https://github.com/OpenEtherCATsociety/SOEM/blob/master/oshw/linux/nicdrv.c#L264 https://github.com/OpenEtherCATsociety/SOEM/blob/master/oshw/linux/nicdrv.c#L332 However the underlying socket is opened without the `SOCK_NONBLOCK` flag: https://github.com/OpenEtherCATsociety/SOEM/blob/master/oshw/linux/nicdrv.c#L146 How are send/recv guaranteed to be...

ABSL_FLAG macro triggers abseil-no-namespace check

2

**Describe the bug** ABSL_FLAG triggers clang-tidy abseil-no-namespace check **Steps to reproduce the bug** $ cat main.cc ``` #include "absl/flags/flag.h" #include "absl/flags/parse.h" ABSL_FLAG(std::string, input, "input", "input file path"); int main(int argc,...

**Describe the bug** debugging/stacktrace uses ABSL_ATTRIBUTE_NO_TAIL_CALL to disable stack optimization. For gcc, the macro gets expanded to __attribute__((optimize("no-optimize-sibling-calls"))) which is known to be broken: https://gcc.gnu.org/wiki/FAQ#A__attribute__.28.28__optimize__.28X.29.29.29_does_not_work_as_expected **Steps to reproduce the bug**...

go: Writer.WriteSchema accepts invalid schema id

1

Writer.WriteSchema accepts schema.ID == 0, which is invalid as per the specification: https://github.com/foxglove/mcap/tree/main/docs/specification#schema-op0x03 https://github.com/foxglove/mcap/blob/8b72814b2c500a6009adb8d9fbad14c03d6a586c/go/mcap/writer.go#L109

This may not be a `rules_foreign_cc` issue but I am hoping someone here has encountered this before and can provide pointers. I have the following setup: ``` cc_test(foo_test) -> cc_library(foo)...

py_wheel: Add support for adding path prefix

6

# 🚀 feature request ### Relevant Rules py_wheel ### Description Support an attribute to add a path prefix to the import path. This will be opposite of the existing attribute...