Alois Klink

Results 173 comments of Alois Klink

> I think you really can't do PR-uploaded snapshots unless you can dockerize your cypress setup and run it all inside a fixed environment Even Docker might not be enough....

> Here are some opportunities that I see: I agree with of these :+1: Some comments I the image snapshot parts: > - move rendering e2e tests to vitest image...

> My suggestion here was for data based snapshots (not image snapshots) where we could extract say the generated SVG as a data snapshot. So, lack of rendering support is...

Another benefit of moving to ESM only, it will make `npm install mermaid` much smaller (I wonder how much CO2 it will save if we cut 15 MiB over hundreds...

> I find this very tempting but also find it is a hard to understand the consequences for downstream projects. Essentially, if a downstream project is using: - `const mermaid...

> Hopefully by merging in the develop branch, those things will be resolved I believe this branch is already up to date with `develop`. The issue is that all of...

> Since fixing things here would be a code-level change, I would not recommend fixing all the lint warnings in a single PR. I can fix for a couple of...

Hi @Boombag0607, thanks for your PR! Just to let you know, there's already a PR open for this (see https://github.com/mermaid-js/mermaid/pull/3604), so we'll probably try to get that one merged first.

This would also greatly help the [`mermaid-cli`](https://github.com/mermaid-js/mermaid-cli) project! It currently uses `puppeteer` to create a browser instance to render Mermaid diagrams, but that's a very very heavy program (and has...

> We just finished the integration of Mermaid in Docusauurs (https://github.com/facebook/docusaurus/pull/7490) Exciting stuff! I'm looking forwards to the next Docusaurus release then! :rocket: I do have a server-side rendering (SSR)...