Alois Klink
Alois Klink
### Git force push changes I've `git rebase`-d onto `develop` (aka commit 7647ae317a7b2130e32777248d25a9c4d24b8f9f) to fix merge conflicts. You can use the following command to view the changes (GitHub's UI isn't...
I've fixed merge conflicts in the `pnpm-lock.yaml` file. It looks like we have a `use-inline-specifiers-lockfile-format=true` config setting in our `.npmrc` file that changes the lockfile setting: https://github.com/mermaid-js/mermaid/blob/e4d2118d4bfa023628a020b7ab1f8c491e6dc523/.npmrc#L3 However, [renovate](https://docs.renovatebot.com/) seems...
> What is the status on this? Sorry for the delay! Since this is a pretty big PR the changes how the MermaidConfig is defined, fixing merge conflicts is a...
I've `git rebase`-d onto https://github.com/mermaid-js/mermaid/commit/c742ac71a4f59455ce3dc0b6ac56d5f9b2baa4d2, aka the latest `develop` branch commit + the https://github.com/mermaid-js/mermaid/commit/38013de7114966e8b1a83396703ef8158bb34466 commit from https://github.com/mermaid-js/mermaid/pull/4602. ```bash git range-diff 9c011abbd424641172b696c038490a36ec99c518..0477a9f68a8d6f474dc792d430ca892d1aa41b66 c742ac71a4f59455ce3dc0b6ac56d5f9b2baa4d2..c29088af019a8180ac2f85d79b890cab4cd5fee5 ``` **Changes:** - Make quadrant chart options TypeScript...
Sorry for accidentally closing this PR (it's my fault, not @sidharthv96!) I wrote `Resolves https://github.com/mermaid-js/mermaid/pull/4112#discussion_r1250397326` in PR https://github.com/mermaid-js/mermaid/pull/4602, so GitHub auto-closed this PR when that one was merged.
> - `@mermaid-js/core`: core apis: > - `@mermaid-js/helper`: wrapper on packages which mermaid rely on > - `@mermaid-js/utils` (or something similar): Including helper package for diagrams > - `@mermaid-js/xxx` (xxx...
> Making it stricter now might break many existing diagrams. It won't for the `stateDiagram` diagrams at least, since right now, trying to render a diagram that starts with `stateDiagram-blah-blah-blah`...
We've had issues with accidentally missing the `.js` extensions before (see https://github.com/mermaid-js/mermaid/issues/4170), so having TypeScript check this for us would be really helpful. Thanks for making this PR, I've been...
> `allowImportingTsExtensions` is nice for application code, but it shouldn’t be used for libraries. It emits the `.ts` extension in the output, both JavaScript and type definitions, which should never...
> @aloisklink Am I correct that you’re not a member of the Mermaid team? It’s nice to get some feedback, but I prefer to get confirmation from the Mermaid team...