Andrew Loeliger
Andrew Loeliger
Ecal Trigger primitive producers need to be looked at be ECAL experts. I don't know who those are off the top of my head, but I'll try to find out.
@mbluj @kbunkow FYI
@zhenbinwu You seem to be missing a commit or file somewhere: ``` ModuleNotFoundError: No module named 'L1Trigger.L1TMuonOverlapPhase2' ```
@mbluj It looks like in constructing the PR to CMSSW, some items were forgotten from https://github.com/cms-sw/cmssw/pull/43687, in particular, a python configuration `L1Trigger/L1TMuonOverlapPhase2`. Could you please take a look at the...
@mbluj We prefer the teams who made the PR to open these up to central CMSSW because other reviewers may have additional comments, and we may not be in the...
@mbluj Thanks. We can help you with anything you may need making the PR here. Let us know if there are any issues.
please test with https://github.com/cms-sw/cmssw/pull/44557
Ahh, okay, I ran into this one earlier. @zhenbinwu In the change to the new GMT muons here: https://github.com/cms-sw/cmssw/blob/5924afffab0edc776e43181159b2493a46b2073b/L1Trigger/Configuration/python/SimL1Emulator_cff.py#L172-L177 The producer/products ultimately come from here: https://github.com/cms-sw/cmssw/blob/5924afffab0edc776e43181159b2493a46b2073b/L1Trigger/Phase2L1GMT/plugins/Phase2L1TGMTSAMuonGhostCleaner.cc#L59-L60 Which changes the name...
I have some fixes (changing inputs to `prompt`) that I will be inserting into the prototype.