cms-sw
Phase 2 GTT L1TrackObjectNtupleMaker fixes
PR description:
This PR aggregates various fixes for the GTT L1TrackObjectNtupleMaker, from https://github.com/cms-l1t-offline/cmssw/pull/1253 and https://github.com/cms-l1t-offline/cmssw/pull/1255
PR validation:
This PR passes: scram b scram b code-checks scram b code-format cmsRun L1TrackObjectNtupleMaker_cfg.py (L1TrackObjectNtupleMaker is not called in any central workflows)
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This is a forward port of https://github.com/cms-l1t-offline/cmssw/pull/1253 and https://github.com/cms-l1t-offline/cmssw/pull/1255
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44911/40190
-
This PR adds an extra 40KB to repository
-
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/L1TTrackMatch/test/L1TrackObjectNtupleMaker.cc modified in PR(s): #44576, #44677
A new Pull Request was created by @NJManganelli for master.
It involves the following packages:
- L1Trigger/L1TTrackMatch (l1, upgrade)
@cmsbuild, @subirsarkar, @srimanob, @aloeliger, @epalencia can you please review it and eventually sign? Thanks. @missirol, @Martin-Grunewald this is something you requested to watch as well. @sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1fbdb7/39271/summary.html
COMMIT: 3e4d298d01361d7b9bd5a626cce7f4b33df4f15a
CMSSW: CMSSW_14_1_X_2024-05-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44911/39271/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 1 lines to the logs
- Reco comparison results: 15 differences found in the comparisons
- DQMHistoTests: Total files compared: 48
- DQMHistoTests: Total histograms compared: 3332476
- DQMHistoTests: Total failures: 12
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3332444
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
- Checked 202 log files, 165 edm output root files, 48 DQM output files
- TriggerResults: no differences found
Dear @epalencia @aloeliger , depending on what the plan is for the Integration branch, I can switch this from draft to ready. The only changes would be those in the IB PRs and any review feedback, nothing else is planned from our side.
@cgsavard
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
