Donn Relacion

Results 9 comments of Donn Relacion

I don't believe your code will work @adamhathcock when you configure Serilog with a sink other than the console. For example, I want to configure Serilog with the sqlserver sink...

Yeah, I am reading the FhirJsonPocoSerializer, and I think there may be places here to avoid empty arrays and objects by using writer.Reset() as you are alluding to. Not sure...

I have this issue as well. Initially, I set my `NUGET_PACKAGES` environment variable to a symlink path pointing to a Dev Drive. I changed the path to point to the...

I think the pragmatic solution you presented should suffice in my opinion

I don't think `ReadOnlySpan` really helps since you do this only once, only a minor reduction in allocation. Maybe just sticking with `IEnumerable` should be enough. To guarantee all the...

Also in the future, we can create a source generator that creates the ClassMapping and EnumMapping removing the need for reflection at runtime.

I've improved my source generator to generate the `ClassMapping` and `EnumMapping` and I get the results below: | Method | Mean | Error | StdDev | Median | Gen0 |...

@mmsmits I've refined the new API that would be helpful for source generating the ModelInspector below: Proposed new API ### ModelInspector ```csharp public ModelInspector(string fhirVersion, IEnumerable classMappings, IEnumerable enumMappings) {...

The `ForTypes` method is no longer necessary since using it will inevitably require reflection. I agree with using the `ForPredefinedMappings` factory method. For ClassMapping and PropertyMapping, yes I agree to...