Almann Goo
Almann Goo
While implementing the Ion C Rust bindings, I had to read through the memory ownership semantics of decimal writing in [ion-binary.c][1]. The problem with this implementation is that although it...
As part of fixing #180, there was a line of code that appears to be a bug: https://github.com/amzn/ion-c/blob/a9af6be3f2ed38d4775257adfa5672c845cac361/ionc/ion_allocation.c#L39-L54 Specifically, `g_ion_alloc_page_list.page_size == ION_ALLOC_PAGE_POOL_PAGE_SIZE_NONE` should not be used as a sentinel for...
Currently, the page pool allocator is per-thread. We should consider allowing it to be concurrent safe (e.g. using atomic compare-and-swap/mutexes) to allow multiple threads to share the pool.
#27 pointed out the use of `malloc.h` in Windows. We should eliminate this if it is not needed (should just use `stdlib.h`).
There is enough complexity (e.g., month/day precision) in the different lengths of binary timestamp to provide examples up-to and including fractional seconds. We have only one large, just the body...
> What is interesting, is what we're calling an implicitly negative exponent, is what other people would call *scale* and not only that, but our restrictions on the *coefficient*/*scale* are...
This is currently fairly confusing, we should rework this section. > I like this, though it is interesting that the least significant bits in our representation correspond to the most...
## Summary There are rules around how duplicate symbol definitions are to be treated which are ambiguous. we propose that we define that duplicate symbol definitions (imported or locally defined)...
I think we should consider having a contributors page to give thanks/credit to folks who helped make Ion possible.
Similar to amzn/ion-rust and partiql/partiql-lang-rust, we should have CI integration. E.g. * https://github.com/amzn/ion-rust/blob/main/.github/workflows/rust.yml * https://github.com/amzn/ion-rust/blob/main/.github/workflows/coverage.yml