Sibtain Ali

Results 150 comments of Sibtain Ali

@s77rt Weirdly enough, its showing a GBR to me in the LHN, while there is an RBR in the workspace chat. ![Screenshot 2024-12-12 at 5 10 43 AM](https://github.com/user-attachments/assets/309784d8-507c-4f13-8a64-0352d16a22c9)

~~Thanks for the proposals everyone.~~ ~~I think @nkdengineer is correct in pointing out that the transaction will be reverted after we change the waypoint. @nkdengineer's [proposal](https://github.com/Expensify/App/issues/52241#issuecomment-2472904877) looks better.~~ ~~Let's go...

> > > Just another note: I'm the first one to explain why this only happens for distance requests for split distances. > > The root cause of the issue...

I reviewed this again. Specifically, I tried to test if the transaction would be reverted after we change the waypoint. Although it seemed like that would be the case initially,...

@nkdengineer Thanks for being honest here. Given that the transaction is not reverted, I'd agree with @FitseTLT that @nkdengineer's proposal is almost the same as @FitseTLT. As such, Let's go...

> > That's what I see as for now: > > > > * `transaction.taxAmount` field value [is used](https://github.com/Expensify/App/blob/633e708dfe3d2aba47dbb2091ba1f0f8683bfaaf/src/components/ReportActionItem/MoneyRequestView.tsx#L134) to display the tax value on the screen mentioned in the...

Ah, my bad. I did not take into account that this was a scan request.

## Reviewer Checklist - [x] I have verified the author checklist is complete (all boxes are checked off). - [x] I verified the correct issue is linked in the `###...